Electrical Conductivity Implementations take2 #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Chris Havlin <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
Fix for nested loop structure when creating field names in Params_Electric (second-preferred method)
State Variable in, fix for DK2014 (add units as a subscript to Pressure & Temperature variable name)
State Variable in fix for SEO3 (addition of unit as subscript to Temperature variable name)
State Variable in fix for UHO2014 (addition of units as subscript to Pressure & Temperature variable names )
State Variable in fix for poe2010 (addition of units as subscript to Pressure and Temperature variable names)
State Variable in fix for sun2019 (addition of units as subscripts for Temperature & Pressure variable names)
State Variable in for wang2006 (addition of units as subscript for Temperature & Pressure variable names)
State Variable in fix for yosh2009 (addition of units as subscript for Pressure & Temperature variable names)
Co-authored-by: Chris Havlin <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
Co-authored-by: Chris Havlin <[email protected]>
exclusion of Hydrogen diffusion experiments
Exclusion of H-D diffusion experiments because of inconsistencies (Novella, 2017 & Sun, 2019) Exclusion of Dai and Karato, 2014 because of experimental design (done at single hydration value) Inclusion of Jones et al, 2012 Correction of Poe 2010 using Jones 2012 wt% Ch2o in stead of original parameters for ppm Ch2o Current Electrical Conductivity functions (Esigs): esig.yosh2009 = yosh2009(T, Ch2o, P); esig.SEO3 = SEO3(T, Ch2o, P); esig.poe2010 = poe2010(T, Ch2o, P); esig.sun2019 = sun2019(T, Ch2o, P); esig.wang2006 = wang2006(T, Ch2o, P); esig.UHO2014 = UHO2014(T, Ch2o, P); esig.jones2012 = jones2012(T, Ch2o, P); *All corresponding individual functions have been updated
This was referenced May 3, 2024
|
This is a clean replacement of #73 ! |
Work In Progress: ec_LUT vol2part
|
@sammykojo , a couple quick organizational notes:
Let me know when this is at a good for me to really dig in. Thanks for all your work on this! |
|
Things to do:
|
|
@sammykojo I just pushed a few changes, be sure to CB_015_ec_melt.m also needs some octave compatibility fixes, but I'm not sure the output from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.