-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VM Description in backup report #8253
Open
truongtx8
wants to merge
8
commits into
vatesfr:master
Choose a base branch
from
truongtx8:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add VM Description in report
Add VM Description in report
Add VM Description
b-Nollet
requested changes
Jan 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for your contribution.
I added a few suggestions to improve what you've done:
- I framed the description of the VM with a {{#if}}{{/if}} to display it only when the VM has a description
- I slightly changed the description display to make it more consistent with the rest of the backup report
- I've modified the changelog message to bring it into line with our habits
There are still two changes that the github interface doesn't allow me to suggest:
- a line
- xo-server-backup-reports minor
should be added to the ‘Packages to release’ section of the changelog (just after- @xen-orchestra/web-core minor
) - the description should be moved from line 9 to line 4 in the markdown template.
If you make these changes, then we can merge your PR as soon as possible.
packages/xo-server-backup-reports/templates/mjml/partials/vmText.hbs
Outdated
Show resolved
Hide resolved
packages/xo-server-backup-reports/templates/markdown/partials/vmText.hbs
Outdated
Show resolved
Hide resolved
Co-authored-by: b-Nollet <[email protected]>
Co-authored-by: b-Nollet <[email protected]>
Co-authored-by: b-Nollet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometime, the name does not provide enough information about the VM, adding more with Description, we will know more which VM has issue with backup.
Checklist
Fixes #007
,See xoa-support#42
,See https://...
)Introduced by
CHANGELOG.unreleased.md
Review process
Notes: