Adopt the new AsyncQueue, remove dependency on all three Fluent drivers, other cleanup
#7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r stacks regardless of whether they use them.
…s out we never use it anyway. This also removes a trivially always-true condition from the `clear()` query.
…d add a few more SQLKit utilities to make the queries more nicer.
…test all database drivers that are available at the time the tests are built. Also use ConsoleKit's logger instead of StreamLogHandler because it's way more readable.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7 +/- ##
===========================================
+ Coverage 73.55% 92.07% +18.51%
===========================================
Files 6 7 +1
Lines 208 227 +19
===========================================
+ Hits 153 209 +56
+ Misses 55 18 -37
|
0xTim
approved these changes
Jun 14, 2024
gwynne
force-pushed
the
asyncify-and-cleanup
branch
5 times, most recently
from
9967023 to
4f067f6
Compare
…ke another whack at the CI
gwynne
force-pushed
the
asyncify-and-cleanup
branch
from
4f067f6 to
9f8f9f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
StoredJobState.completedhas been removed, since we never actually used it. This helpfully improves the behavior of theclear()query.AsyncQueueprotocol and no longer has to go back and forth between futures.Sendablewarning.