Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(marketing features): Adding Product Marketing Feature #268

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

thoven87
Copy link
Contributor

@thoven87 thoven87 commented Aug 3, 2024

Adding Product marketing features

This is used to display product features see the (Stripe API documentation)[https://docs.stripe.com/api/products/update#update_product-marketing_features]

@thoven87 thoven87 requested a review from Andrewangeta as a code owner August 3, 2024 01:54
Copy link
Member

@Andrewangeta Andrewangeta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes

@thoven87
Copy link
Contributor Author

thoven87 commented Aug 5, 2024

@Andrewangeta I updated the code to make marketingFeatures optional.

@thoven87 thoven87 requested a review from Andrewangeta August 6, 2024 20:18
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1d9fbc3). Learn more about missing BASE report.

Files Patch % Lines
Sources/StripeKit/Products/Products/Product.swift 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             main    #268   +/-   ##
======================================
  Coverage        ?   2.15%           
======================================
  Files           ?     194           
  Lines           ?    8868           
  Branches        ?       0           
======================================
  Hits            ?     191           
  Misses          ?    8677           
  Partials        ?       0           
Files Coverage Δ
Sources/StripeKit/Products/Products/Product.swift 0.00% <0.00%> (ø)

@Andrewangeta Andrewangeta merged commit 7d3452d into vapor-community:main Aug 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants