Extend swift-crypto allowed version range #249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per https://github.com/apple/swift-crypto/releases/tag/3.0.0 the version 3.0 should be allowed in the range for swift-crypto. Not allowing this version makes using stripe-kit incompatible with jwt-kit 5 beta.
gwynne
reviewed
Mar 4, 2024
| @@ -14,7 +14,7 @@ let package = Package( | |||
| ], | |||
| dependencies: [ | |||
| .package(url: "https://github.com/swift-server/async-http-client.git", from: "1.1.0"), | |||
| .package(url: "https://github.com/apple/swift-crypto.git", "1.0.0" ..< "3.0.0"), | |||
| .package(url: "https://github.com/apple/swift-crypto.git", "1.0.0" ..< "4.0.0"), | |||
There was a problem hiding this comment.
Given the JWTKit limitation on the minimum version, would it make more sense to just do from: "3.0.0" here? The only reason most Vapor packages don't do that is to try to remain compatible with other dependencies with the same issue.
There was a problem hiding this comment.
Given that it might prevent some people to get the latest releases of stripe-kit (e.g. a dependency set to from: "2.0.0" in a Package.swift file), I guess keeping the extended range would be more appropriate?
I’m ok for both solutions though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://github.com/apple/swift-crypto/releases/tag/3.0.0 the version 3.0 should be allowed in the range for swift-crypto.
Not allowing this version makes using stripe-kit incompatible with jwt-kit 5 beta.