Skip to content

Commit

Permalink
Remove the custom optionset again
Browse files Browse the repository at this point in the history
  • Loading branch information
mattesmohr committed Dec 30, 2024
1 parent 355e040 commit f986829
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 44 deletions.
14 changes: 13 additions & 1 deletion Sources/HTMLKit/Abstraction/Attributes/BasicAttributes.swift
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,19 @@ public protocol AutocompleteAttribute: Attribute {
/// - Parameter value: The value to be expected
///
/// - Returns: The element
func autocomplete(_ value: OrderedSet<Values.Completion>) -> Self
func autocomplete(_ value: Values.Completion) -> Self

/// Specify an auto completion.
///
/// ```swift
/// Input()
/// .autocomplete([.organization, .organizationTitle])
/// ```
///
/// - Parameter values: The values to be expected
///
/// - Returns: The element
func autocomplete(_ values: OrderedSet<Values.Completion>) -> Self
}

extension AutocompleteAttribute where Self: ContentNode {
Expand Down
8 changes: 6 additions & 2 deletions Sources/HTMLKit/Abstraction/Elements/BodyElements.swift
Original file line number Diff line number Diff line change
Expand Up @@ -17826,8 +17826,12 @@ extension Form: GlobalAttributes, GlobalEventAttributes, GlobalAriaAttributes, A
return mutate(autocomplete: "off")
}

public func autocomplete(_ value: OrderedSet<Values.Completion>) -> Form {
return mutate(autocomplete: value.map { $0.rawValue }.joined(separator: " "))
public func autocomplete(_ value: Values.Completion) -> Form {
return mutate(autocomplete: value.rawValue)
}

public func autocomplete(_ values: OrderedSet<Values.Completion>) -> Form {
return mutate(autocomplete: values.map { $0.rawValue }.joined(separator: " "))
}

public func encoding(_ value: Values.Encoding) -> Form {
Expand Down
24 changes: 18 additions & 6 deletions Sources/HTMLKit/Abstraction/Elements/FormElements.swift
Original file line number Diff line number Diff line change
Expand Up @@ -191,8 +191,12 @@ extension Input: GlobalAttributes, GlobalEventAttributes, AcceptAttribute, Alter
return mutate(autocomplete: "off")
}

public func autocomplete(_ value: OrderedSet<Values.Completion>) -> Input {
return mutate(autocomplete: value.map { $0.rawValue }.joined(separator: " "))
public func autocomplete(_ value: Values.Completion) -> Input {
return mutate(autocomplete: value.rawValue)
}

public func autocomplete(_ values: OrderedSet<Values.Completion>) -> Input {
return mutate(autocomplete: values.map { $0.rawValue }.joined(separator: " "))
}

public func checked() -> Input {
Expand Down Expand Up @@ -826,8 +830,12 @@ extension Select: GlobalAttributes, GlobalEventAttributes, AutocompleteAttribute
return mutate(autocomplete: "off")
}

public func autocomplete(_ value: OrderedSet<Values.Completion>) -> Select {
return mutate(autocomplete: value.map { $0.rawValue }.joined(separator: " "))
public func autocomplete(_ value: Values.Completion) -> Select {
return mutate(autocomplete: value.rawValue)
}

public func autocomplete(_ values: OrderedSet<Values.Completion>) -> Select {
return mutate(autocomplete: values.map { $0.rawValue }.joined(separator: " "))
}

public func disabled() -> Select {
Expand Down Expand Up @@ -1081,8 +1089,12 @@ extension TextArea: GlobalAttributes, GlobalEventAttributes, GlobalAriaAttribute
return mutate(autocomplete: "off")
}

public func autocomplete(_ value: OrderedSet<Values.Completion>) -> TextArea {
return mutate(autocomplete: value.map { $0.rawValue }.joined(separator: " "))
public func autocomplete(_ value: Values.Completion) -> TextArea {
return mutate(autocomplete: value.rawValue)
}

public func autocomplete(_ values: OrderedSet<Values.Completion>) -> TextArea {
return mutate(autocomplete: values.map { $0.rawValue }.joined(separator: " "))
}

public func columns(_ size: Int) -> TextArea {
Expand Down
13 changes: 1 addition & 12 deletions Sources/HTMLKit/Abstraction/Tokens/ValueTokens.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1024,7 +1024,7 @@ public enum Values {
/// }
/// .autocomplete([.organization, .organizationTitle])
/// ```
public enum Completion: String, OptionSet {
public enum Completion: String {

/// Enables completion
case on
Expand Down Expand Up @@ -1189,14 +1189,3 @@ public enum Values {
case messagingProtocol = "impp"
}
}

extension OrderedSet where Element == Values.Completion {

public static var off: OrderedSet<Values.Completion> {
return [.off]
}

public static var on: OrderedSet<Values.Completion> {
return [.on]
}
}
18 changes: 0 additions & 18 deletions Sources/HTMLKit/Framework/Extensions/OrderedSet+OptionSet.swift

This file was deleted.

3 changes: 0 additions & 3 deletions Sources/HTMLKit/Framework/Primitives/Shared/OptionSet.swift

This file was deleted.

8 changes: 6 additions & 2 deletions Tests/HTMLKitTests/AttributesTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,12 @@ final class AttributesTests: XCTestCase {
return self.mutate(async: "async")
}

func autocomplete(_ value: OrderedSet<Values.Completion>) -> Tag {
return mutate(autocomplete: value.map { $0.rawValue }.joined(separator: " "))
func autocomplete(_ value: Values.Completion) -> Tag {
return mutate(autocomplete: value.rawValue)
}

func autocomplete(_ values: OrderedSet<Values.Completion>) -> Tag {
return mutate(autocomplete: values.map { $0.rawValue }.joined(separator: " "))
}

func autoplay() -> Tag {
Expand Down

0 comments on commit f986829

Please sign in to comment.