Skip to content

Commit

Permalink
Removed the HasCart, ComputesShipToName and `FillsCommonCheckoutA…
Browse files Browse the repository at this point in the history
…ttributes` traits
  • Loading branch information
fulopattila122 committed Mar 30, 2024
1 parent 6487d7c commit 40ee383
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 130 deletions.
4 changes: 4 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,10 @@
- `setTaxesAmount()`
- `itemsTotal()`
- BC: The unused `$config` parameter has been removed from the `RequestStore` checkout driver constructor
- BC: Removed the following traits from the Checkout module:
- `HasCart`
- `ComputesShipToName`
- `FillsCommonCheckoutAttributes`
- BC: Added the `deleteByType()` and `clear()` methods to the `AdjustmentCollection` interface
- BC: The `Adjustable::itemsTotal()` has been renamed to `preAdjustmentTotal()`
- BC: The `invalidateAdjustments()` method has been added to the `Adjustable` interface
Expand Down
4 changes: 4 additions & 0 deletions src/Checkout/Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,10 @@
- Changed minimum Laravel version to v10.38.2
- Changed minimal Enum requirement to v4.2
- Added the `BillpayerChanged` event
- BC: Removed the following traits:
- `HasCart`
- `ComputesShipToName`
- `FillsCommonCheckoutAttributes`
- BC: The `Checkout` interface now extends the `ArrayAccess` and the `Shippable` interfaces (until here, only the concrete classes have implementation it)
- BC: Added the `?CheckoutSubject` return type to the `getCart()` method of the `Checkout` interface
- BC: The unused `$config` parameter has been removed from the `RequestStore` checkout driver constructor
Expand Down
4 changes: 0 additions & 4 deletions src/Checkout/Drivers/BaseCheckoutStore.php
Original file line number Diff line number Diff line change
Expand Up @@ -209,16 +209,12 @@ public function offsetGet(mixed $offset): mixed

abstract public function clear(): void;

/** @todo add this to the interface in v4 */
abstract public function getShippingAmount(): DetailedAmount;

/** @todo add this to the interface in v4 */
abstract public function setShippingAmount(float|DetailedAmount $amount): void;

/** @todo add this to the interface in v4 */
abstract public function getTaxesAmount(): DetailedAmount;

/** @todo add this to the interface in v4 */
abstract public function setTaxesAmount(float|DetailedAmount $amount): void;

/**
Expand Down
37 changes: 0 additions & 37 deletions src/Checkout/Traits/ComputesShipToName.php

This file was deleted.

43 changes: 0 additions & 43 deletions src/Checkout/Traits/FillsCommonCheckoutAttributes.php

This file was deleted.

46 changes: 0 additions & 46 deletions src/Checkout/Traits/HasCart.php

This file was deleted.

0 comments on commit 40ee383

Please sign in to comment.