reuse encoders for ordinal variables [type:bug] #251
Closed
Task list completed / task-list-completed
succeeded
Feb 22, 2024 in 0s
4 / 4 tasks completed
All tasks have been completed
Details
Required Tasks
| Task | Status |
|---|---|
| Only quick fix. Sklearn recommends against using LabelEncoder for features, I have not changed this. | Incomplete |
| Results in error when there are unknown feature classes in e.g. X_syn (compared to X_gt). This is safer, though does mean we cannot evaluate easily on a very small real dataset. If we want to avoid this, we could use OrdinalEncoder instead, which allows ignore_unknown argument to be passed | Incomplete |
| I have followed the Contribution Guidelines and Code of Conduct | Completed |
| I have commented my code following the van der Schaar Lab Styleguide | Completed |
| I have labelled this PR with the relevant Type labels | Completed |
| My changes are covered by tests | Completed |
Loading