-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hex encode the data in dump test #1637
Conversation
Signed-off-by: Madelyn Olson <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## unstable #1637 +/- ##
============================================
- Coverage 71.04% 70.86% -0.18%
============================================
Files 121 121
Lines 65174 65176 +2
============================================
- Hits 46304 46189 -115
- Misses 18870 18987 +117 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! MacOS is weird...
The comments above the changed strings were supposed to point to the right parts inside the strings, to make it easier to read the strings.
I think I found it. MacOS is running TCL 8.5, right? https://www.tcl-lang.org/man/tcl8.5/TclCmd/Tcl.htm#M27
This seems to have change in TCL 8.6 https://www.tcl-lang.org/man/tcl8.6/TclCmd/Tcl.htm#M27 to
|
r config set rdb-version-check strict | ||
assert_equal {bar} [r get foo] | ||
set e | ||
} {OK} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason I used catch instead of letting it fail immediately was to restore the config afterwards so even if this test case fails, it doesn't affect other test cases. Maybe that's too fancy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're traveling, I'll apply the suggestions and merge it so we can fix daily.
Signed-off-by: Viktor Söderqvist <[email protected]>
Addresses the failure here: https://github.com/valkey-io/valkey/actions/runs/13000845302/job/36259016156#step:5:7272. This change does three things: 1. For some reason TCL 8.5 (which is used on macos) is handling `\x03ba` as `\0xba`, according to https://www.tcl-lang.org/man/tcl8.5/TclCmd/Tcl.htm#M27 so we encode "bar" using hex escapes too. 2. Fix a spacing issue. 3. Make it so that if the restore fails, it immediately errors. --------- Signed-off-by: Madelyn Olson <[email protected]> Signed-off-by: Viktor Söderqvist <[email protected]> Co-authored-by: Viktor Söderqvist <[email protected]>
Addresses the failure here: https://github.com/valkey-io/valkey/actions/runs/13000845302/job/36259016156#step:5:7272.
This change does three things:
\x03ba
as\0xba
, according to https://www.tcl-lang.org/man/tcl8.5/TclCmd/Tcl.htm#M27 so we encode "bar" using hex escapes too.