Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IP address validation in node address update #1633

Conversation

stav-bentov
Copy link
Contributor

Prevent Updating Node Address with Invalid IP

  • Added a check to ensure that the node address is not updated if a valid IP address cannot be obtained.
  • This enhancement addresses potential issues where invalid IP addresses (i.e., empty strings or "?" placeholders) could be used to update node address.

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.99%. Comparing base (9071a5c) to head (bd55493).
Report is 9 commits behind head on unstable.

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #1633      +/-   ##
============================================
+ Coverage     70.85%   70.99%   +0.13%     
============================================
  Files           121      121              
  Lines         65169    65175       +6     
============================================
+ Hits          46176    46269      +93     
+ Misses        18993    18906      -87     
Files with missing lines Coverage Δ
src/cluster_legacy.c 87.20% <100.00%> (+<0.01%) ⬆️

... and 18 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant