Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build service worker without writing it to FS (#20909) (CP: 24.5) #20918

Merged
merged 1 commit into from
Jan 27, 2025
Merged

fix: build service worker without writing it to FS (#20909) (CP: 24.5) #20918

merged 1 commit into from
Jan 27, 2025

Conversation

tepi
Copy link
Contributor

@tepi tepi commented Jan 27, 2025

No description provided.

@tepi tepi requested a review from mcollovati January 27, 2025 12:09
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

Test Results

1 148 files  ± 0  1 148 suites  ±0   1h 28m 12s ⏱️ - 1m 55s
7 540 tests ± 0  7 487 ✅ + 1  53 💤 ±0  0 ❌ ±0 
7 844 runs  +16  7 786 ✅ +20  58 💤  - 3  0 ❌ ±0 

Results for commit c3bf7b9. ± Comparison against base commit d98a050.

@mcollovati mcollovati merged commit 049dca3 into 24.5 Jan 27, 2025
26 checks passed
@mcollovati mcollovati deleted the fix/build-sw-without-writing-cp-24.5 branch January 27, 2025 13:17
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollovati mcollovati mcollovati approved these changes

Assignees
No one assigned
Labels
cherry pick Released with Vaadin 24.5.11 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tepi @vaadin-bot @mcollovati @vursen