Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Store the exception and not an array with the exception for uncaught promise exceptions" #20877

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Revert "fix: Store the exception and not an array with the exception for uncaught promise exceptions" #20877

merged 1 commit into from
Jan 20, 2025

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jan 18, 2025

Reverts #20840

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
1428 New issues
9 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Artur-
Copy link
Member Author

Artur- commented Jan 18, 2025 •
edited
Loading

The PR caused other issues

@github-actions GitHub Actions
Copy link

Test Results

1 165 files  ± 0  1 165 suites  ±0   1h 29m 27s ⏱️ - 5m 36s
7 625 tests ± 0  7 569 ✅ ± 0  56 💤 ±0  0 ❌ ±0 
7 954 runs   - 34  7 889 ✅  - 34  65 💤 ±0  0 ❌ ±0 

Results for commit f6ee36c. ± Comparison against base commit 32c4914.

@Artur- Artur- requested a review from caalador January 19, 2025 07:39
@caalador caalador merged commit 0aac285 into main Jan 20, 2025
26 checks passed
@caalador caalador deleted the revert-20840-store-exception branch January 20, 2025 04:40
vaadin-bot pushed a commit that referenced this pull request Jan 20, 2025
@Artur- @vaadin-bot
Revert "fix: Store the exception and not an array with the exception …
75bb7cd 
…for unca…" (#20877)

This reverts commit 3fe8592.
vaadin-bot added a commit that referenced this pull request Jan 20, 2025
@vaadin-bot @Artur-
Revert "fix: Store the exception and not an array with the exception …
c9e242e 
…for unca…" (#20877) (#20880)

This reverts commit 3fe8592.

Co-authored-by: Artur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caalador caalador caalador approved these changes

Assignees
No one assigned
Labels
cherry-picked-24.6 target/24.6 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Artur- @caalador @vaadin-bot