Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make route config errors more prominent #20847

Merged
merged 5 commits into from
Jan 16, 2025
Merged

fix: make route config errors more prominent #20847

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47842d4
fix: make route config errors more prominent
tepi Jan 15, 2025
fe6dbf0
add note of RouteAlias must be unique
tepi Jan 15, 2025
a4fc03e
fix error message
tepi Jan 15, 2025
1a2668b
move error msgs to constants
tepi Jan 15, 2025
51a0e32
Merge branch 'main' into fix/make-route-config-errors-more-prominent
tepi Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions flow-server/src/main/java/com/vaadin/flow/router/internal/RouteSegment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,9 +791,9 @@ private RuntimeException ambigousTarget(Class<? extends Component> target) {

String messageFormat;
if (isParameter()) {
messageFormat = "Navigation targets must have unique routes, found navigation targets '%s' and '%s' with parameter have the same route.";
messageFormat = "Navigation targets (@Route and @RouteAlias values) must be unique, found navigation targets '%s' and '%s' with parameter having the same route.";
caalador marked this conversation as resolved.
Show resolved Hide resolved
} else {
messageFormat = "Navigation targets must have unique routes, found navigation targets '%s' and '%s' with the same route.";
messageFormat = "Navigation targets (@Route and @RouteAlias values) must be unique, found navigation targets '%s' and '%s' with the same route.";
}

String message = String.format(messageFormat,
Expand Down
Loading