fix: Navigate with full url #20846
fix: Navigate with full url #20846
Conversation
There was a problem hiding this comment.
Tested locally and it works fine.
I just wonder if we should raise an error on the client side if the given URL is absolute and does not match document.baseURI.
With Vaadin router, an error is raised, so it would probably be good to have a similar behavior also with React.
Fix navigating with full url for instance when adding a query parameter at the end. Fixes #19580
caalador
force-pushed
the
issues/19580-queryparam
branch
from
4d57abc to
1c2d6ed
Compare
|
I guess we should, but I wonder should it be part of this fix or should we have an enhancement ticket for it. |
|
Yeah, it definitely can be done separately. I'll create the ticket. |
Fix navigating with full url for instance when adding a query parameter at the end. Fixes #19580
Fix navigating with full url for instance when adding a query parameter at the end. Fixes #19580 Co-authored-by: caalador <[email protected]>
|
This ticket/PR has been released with Vaadin 24.7.0.alpha5 and is also targeting the upcoming stable 24.7.0 version. |
Fix navigating with full url
for instance when adding a
query parameter at the end.
Fixes #19580