-
Notifications
You must be signed in to change notification settings - Fork 169
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Show client side exception messages when not in production (#1030)
When not in production mode, this causes any exception which happens in the browser to be shown to the developer so it is clear that something is wrong. Client side exceptions are always logged to the browser console, regardless of the production mode status.
- Loading branch information
Showing
9 changed files
with
168 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...ntext/src/main/java/com/vaadin/hummingbird/uitest/ui/ClientSideExceptionHandlingView.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| /* | ||
| * Copyright 2000-2016 Vaadin Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.vaadin.hummingbird.uitest.ui; | ||
|
|
||
| import com.vaadin.hummingbird.html.Button; | ||
| import com.vaadin.hummingbird.html.Div; | ||
| import com.vaadin.hummingbird.router.View; | ||
|
|
||
| public class ClientSideExceptionHandlingView extends Div implements View { | ||
|
|
||
| static final String CAUSE_EXCEPTION_ID = "causeException"; | ||
| private Button causeException; | ||
|
|
||
| public ClientSideExceptionHandlingView() { | ||
| causeException = new Button("Cause client side exception", e -> { | ||
| getUI().get().getPage().executeJavaScript("null.foo"); | ||
| }); | ||
| causeException.setId(CAUSE_EXCEPTION_ID); | ||
| add(causeException); | ||
| } | ||
| } |
52 changes: 52 additions & 0 deletions
52
...context/src/test/java/com/vaadin/hummingbird/uitest/ui/ClientSideExceptionHandlingIT.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /* | ||
| * Copyright 2000-2016 Vaadin Ltd. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); you may not | ||
| * use this file except in compliance with the License. You may obtain a copy of | ||
| * the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT | ||
| * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the | ||
| * License for the specific language governing permissions and limitations under | ||
| * the License. | ||
| */ | ||
| package com.vaadin.hummingbird.uitest.ui; | ||
|
|
||
| import org.junit.Assert; | ||
| import org.junit.Test; | ||
| import org.openqa.selenium.By; | ||
| import org.openqa.selenium.WebElement; | ||
|
|
||
| import com.vaadin.hummingbird.testutil.PhantomJSTest; | ||
|
|
||
| public class ClientSideExceptionHandlingIT extends PhantomJSTest { | ||
|
|
||
| private static final By ERROR_LOCATOR = By.className("v-system-error"); | ||
|
|
||
| @Test | ||
| public void developmentModeExceptions() { | ||
| open(); | ||
| causeException(); | ||
|
|
||
| WebElement errorMessage = findElement(ERROR_LOCATOR); | ||
| Assert.assertTrue(errorMessage.getText(), | ||
| errorMessage.getText().contains("null is not an object")); | ||
| } | ||
|
|
||
| @Test | ||
| public void productionModeExceptions() { | ||
| openProduction(); | ||
| causeException(); | ||
|
|
||
| Assert.assertFalse(isElementPresent(ERROR_LOCATOR)); | ||
| } | ||
|
|
||
| private void causeException() { | ||
| findElement(By.id(ClientSideExceptionHandlingView.CAUSE_EXCEPTION_ID)) | ||
| .click(); | ||
| } | ||
|
|
||
| } |