Dedicated container for database #482
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaannz
reviewed
Jan 22, 2025
| ) error { | ||
| image := pgsqlFlags.Image | ||
| currentReplicas := systemd.CurrentReplicaCount(podman.PgsqlService) | ||
| log.Debug().Msgf("Current HUB replicas running are %d.", currentReplicas) |
There was a problem hiding this comment.
Suggested change
| log.Debug().Msgf("Current HUB replicas running are %d.", currentReplicas) | |
| log.Debug().Msgf("Current pgsql replicas running are %d.", currentReplicas) |
| log.Debug().Msgf("Current HUB replicas running are %d.", currentReplicas) | ||
|
|
||
| if pgsqlFlags.Replicas == 0 { | ||
| log.Debug().Msg("No pgsql requested.") |
There was a problem hiding this comment.
Suggested change
| log.Debug().Msg("No pgsql requested.") | |
| log.Info().Msg(L("No Postgres container requested.")) |
| log.Debug().Msg("No pgsql requested.") | ||
| } | ||
| if !pgsqlFlags.IsChanged { | ||
| log.Info().Msgf(L("No changes requested for hub. Keep %d replicas."), currentReplicas) |
There was a problem hiding this comment.
Suggested change
| log.Info().Msgf(L("No changes requested for hub. Keep %d replicas."), currentReplicas) | |
| log.Info().Msgf(L("No changes requested for pgsql. Keep %d replicas."), currentReplicas) |
| if err := cnx.WaitForHealthcheck(); err != nil { | ||
| return err | ||
| } | ||
| // Now the servisce is up and ready, the admin credentials are no longer needed |
There was a problem hiding this comment.
Suggested change
| // Now the servisce is up and ready, the admin credentials are no longer needed | |
| // Now the service is up and ready, the admin credentials are no longer needed |
| @@ -0,0 +1,191 @@ | |||
| // SPDX-FileCopyrightText: 2024 SUSE LLC | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2024 SUSE LLC | |
| // SPDX-FileCopyrightText: 2025 SUSE LLC |
| OLD_VERSION={{ .OldVersion }} | ||
| NEW_VERSION={{ .NewVersion }} | ||
| FAST_UPGRADE=--link | ||
| FAST_UPGRADE= #--link |
| @@ -209,3 +209,21 @@ Leave it unset if you want to keep the previous number of replicas. | |||
| _ = utils.AddFlagToHelpGroupID(cmd, "saline-replicas", "saline-container") | |||
| _ = utils.AddFlagToHelpGroupID(cmd, "saline-port", "saline-container") | |||
| } | |||
|
|
|||
| // AddPgsqlFlags adds hub XML-RPC related parameters to cmd. | |||
There was a problem hiding this comment.
Suggested change
| // AddPgsqlFlags adds hub XML-RPC related parameters to cmd. | |
| // AddPgsqlFlags adds postgres related parameters to cmd. |
| _ = utils.AddFlagToHelpGroupID(cmd, "pgsql-replicas", "pgsql-container") | ||
| } | ||
|
|
||
| // AddUpgradePgsqlFlags adds hub XML-RPC related parameters to cmd upgrade. |
There was a problem hiding this comment.
Suggested change
| // AddUpgradePgsqlFlags adds hub XML-RPC related parameters to cmd upgrade. | |
| // AddUpgradePgsqlFlags adds postgres related parameters to cmd upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Current state:
Works with the image from uyuni-project/uyuni#9469
mgradm install podman --pgsql-image <image> --pgsql-tag <tag>Uses workarounds for the issues discussed in https://github.com/SUSE/spacewalk/issues/25363
Missing kubernetes.
Test coverage
No tests: add explanation
No tests: already covered
Unit tests were added
DONE
Links
Issue(s): #
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test(see below)Before you merge
Check How to branch and merge properly!