Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update libvirt terraform provider #1017

Closed
wants to merge 1 commit into from

Conversation

rjmateus
Copy link
Member

Signed-off-by: Ricardo Mateus [email protected]

What does this PR change?

use uyuni terraform libvirt proivder lateste version

@rjmateus rjmateus marked this pull request as draft November 29, 2021 15:52
@SchoolGuy
Copy link
Contributor

SchoolGuy commented Feb 7, 2022

@rjmateus Would you mind if I rebase this PR against master again? The branch is 27 commits behind master.

Edit: I am aware that we have a branch with 0.6.12 but we only have 0.6.11 in Tumbleweed and thus this branch is more convenient.

@aaannz
Copy link
Contributor

aaannz commented Feb 7, 2022

Also as mentioned before, we should switch to 0.6.14 already because of dmacvicar/terraform-provider-libvirt#916

Servers running openssh 8.8 and newer will not work with older libvirt providers when using ssh access.

@SchoolGuy
Copy link
Contributor

@aaannz Does that mean we close this PR?

@aaannz
Copy link
Contributor

aaannz commented Feb 7, 2022

@aaannz Does that mean we close this PR?

There is no other PR AFAIK, so I am just suggesting to update this PR to instead of switching to 0.6.11 to switch to 0.6.14.

@SchoolGuy
Copy link
Contributor

The other PR I am talking about is #1023

So we either switch this or the other... :)

@aaannz
Copy link
Contributor

aaannz commented Feb 7, 2022

Ah, I missed that one. Then yeah, this should be closed.

@rjmateus
Copy link
Member Author

rjmateus commented Feb 7, 2022

Thanks @SchoolGuy
yes this should be closed, and the other one change to 0.6.14 as @aaannz was saying

@nodeg nodeg deleted the update_libvirt_provider_0_6_11 branch December 6, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants