Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update build instructions #3009

Merged
merged 3 commits into from
Jan 14, 2025
Merged

Update build instructions #3009

merged 3 commits into from
Jan 14, 2025

Conversation

avolkov-intel
Copy link
Contributor

@avolkov-intel avolkov-intel commented Dec 5, 2024 •
edited
Loading

Description

Update build instructions for windows examples and fix minor errors in instructions

Checklist to comply with before moving PR from draft:

PR completeness and readability

  • I have reviewed my changes thoroughly before submitting this pull request.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have updated the documentation to reflect the changes or created a separate PR with update and provided its number in the description, if necessary.
  • Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
  • I have added a respective label(s) to PR if I have a permission for that.
  • I have resolved any merge conflicts that might occur with the base branch.

Testing

  • I have run it locally and tested the changes extensively.
  • All CI jobs are green or I have provided justification why they aren't.
  • I have extended testing suite if new functionality was introduced in this PR.

@avolkov-intel avolkov-intel added the docs Issue/PR related to oneDAL docs label Dec 5, 2024
@avolkov-intel
Copy link
Contributor Author

@Alexandr-Solovev @Vika-F could you review these changes, please

@avolkov-intel avolkov-intel marked this pull request as ready for review January 13, 2025 13:57
@avolkov-intel
Copy link
Contributor Author

@david-cortes-intel @Alexandr-Solovev could you review the recent changes, please?

Alexandr-Solovev
Alexandr-Solovev approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Alexandr-Solovev Alexandr-Solovev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avolkov-intel avolkov-intel merged commit 04ce57c into uxlfoundation:main Jan 14, 2025
9 of 11 checks passed
@david-cortes-intel david-cortes-intel mentioned this pull request Jan 14, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vika-F Vika-F Vika-F left review comments

@david-cortes-intel david-cortes-intel david-cortes-intel approved these changes

@Alexandr-Solovev Alexandr-Solovev Alexandr-Solovev approved these changes

@maria-Petrova maria-Petrova Awaiting requested review from maria-Petrova maria-Petrova is a code owner

@Alexsandruss Alexsandruss Awaiting requested review from Alexsandruss Alexsandruss is a code owner

Assignees
No one assigned
Labels
docs Issue/PR related to oneDAL docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@avolkov-intel @Vika-F @Alexandr-Solovev @david-cortes-intel