Skip to content

Commit

Permalink
Fixed extra quotations marks in git tag.
Browse files Browse the repository at this point in the history
  • Loading branch information
snarkhunter committed Dec 20, 2016
1 parent 2c53172 commit 28db835
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions make_dist
Original file line number Diff line number Diff line change
Expand Up @@ -235,23 +235,24 @@ try:
tag += "--" + comment
# Check and/or fix the tag if it's not legal
proc = subprocess.Popen(['git', 'check-ref-format', '--normalize',
'--allow-onelevel', '"'+tag+'"'],
'--allow-onelevel', tag],
stdout=subprocess.PIPE, stderr=subprocess.PIPE)
stdoutdata, stderrdata = proc.communicate()
if proc.returncode == 0: # success
tag = stdoutdata.strip()
print >> sys.stderr, "tag is -->", tag, "<--"
else:
print >> sys.stderr, "Failed to convert '%s' to a legal tag." % tag
print >> sys.stderr, "Using '%s' instead." % oldtag
tag = oldtag

if not dryrun:
osCall('git', 'commit', '-m', commit_msg)
osCall('git', 'tag')
osCall('git', 'tag', tag)
osCall('git', 'push', 'origin', tag)
else:
print >> sys.stderr, "Dry run! Not running:"
print >> sys.stderr, '*** git commit -m "%s"' % commit_msg
print >> sys.stderr, '*** git commit -m %s' % commit_msg
print >> sys.stderr, '*** git tag', tag
print >> sys.stderr, '*** git push origin %s' % tag

Expand Down

0 comments on commit 28db835

Please sign in to comment.