Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom view for easy access to the Rascal debugger #564
Add custom view for easy access to the Rascal debugger #564
Changes from all commits
b54a243
45cfa49
9351f4f
6c65a03
01035c7
07418db
4320b9e
cbbb04f
77cd7c1
1e13fc8
cd479cd
122a95b
25ac3f8
65197d5
3f9cc88
3a41a23
603a52d
2580d9f
d4b0aac
6a1a8a7
57352e6
484fd1f
01b45fd
a644b26
f640a5b
9c0440b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I recommend using a
FileDecoratorProvider
to highlight the active terminal instead of "abusing" the highlights concept.Each of the
RascalReplNode
will need a unique Uri and the decorator willvscode.window.activeTerminal
onDidChangeActiveTerminal
event to refresh the decoration on the previous and newly active UrisDecorations can give the active node a badge like "🎯" and give currently-debug-enabled nodes a badge like "🐞"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a nice trick indeed :) but in a way, "abusing" a different concept. As a terminal is not a file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah,
FileDecoratorProvider
is an awkward name. It can decorate anything with aUri
. The decorations are most visible in a TreeView, but they also appear on editor tabs.