Fix rename refactoring type errors #559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
| @@ -215,7 +215,7 @@ public InterruptibleFuture<ITuple> getRename(ITree cursorTree, Set<ISourceLocati | |||
| } catch (Throw e) { | |||
| if (e.getException() instanceof IConstructor) { | |||
| var exception = (IConstructor)e.getException(); | |||
| if (exception.getType().getAbstractDataType().getName().equals("RenameException")) { | |||
| if (exception.getName().contains("Rename")) { | |||
There was a problem hiding this comment.
Is there anyway that now or in the future user code is called that could throw an exception? If so, is "having Rename" in the name discerning enough? Maybe we can also check the type including the "package" part to make sure it is an "official" Rename exception?
| @@ -27,6 +27,7 @@ POSSIBILITY OF SUCH DAMAGE. | |||
| module lang::rascal::tests::rename::Grammars | |||
|
|
|||
| import lang::rascal::tests::rename::TestUtils; | |||
| import lang::rascal::lsp::refactor::Exception; | |||
There was a problem hiding this comment.
Extra import but no use of the import? The same goes for imports in ProjectOnDisk.rsc.
There was a problem hiding this comment.
These imports fix errors regarding undefined @expected exceptions in these modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.