Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDN service annotation support #642

Merged
merged 4 commits into from
Feb 16, 2024
Merged

CDN service annotation support #642

merged 4 commits into from
Feb 16, 2024

Conversation

smlx
Copy link
Member

@smlx smlx commented Feb 15, 2024

Newer versions of the AWS load balancer controller change the default behaviour of LoadBalancer objects to be internal (private IP address) rather than internet-facing. The interface for making a LoadBalancer internet-facing is now an annotation on the k8s service object.

So this PR adds support for annotations on the CDN service, which is the only one intended to be used as a LoadBalancer.

@smlx smlx force-pushed the service-annotations branch from 52bde41 to 35e52e1 Compare February 15, 2024 06:25
@smlx smlx requested a review from tobybellwood February 15, 2024 06:30
@smlx smlx marked this pull request as ready for review February 15, 2024 06:30
@tobybellwood
Copy link
Member

I stumbled into issues testing locally, as the kubectl container couldn't build (the alpine pkgs wouldn't install kubectl and jq) - but I replaced it with uselagoon/tests:latest - which has them preinstalled, and it worked fine.

------------------------------------------------------------------------------------------------------------------------
==> Logs of container lagoon-logging-7l8a9hjbxf-logs-dispatcher-test-cdn-service-annotations
------------------------------------------------------------------------------------------------------------------------
fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/main/x86_64/APKINDEX.tar.gz
fetch https://dl-cdn.alpinelinux.org/alpine/v3.19/community/x86_64/APKINDEX.tar.gz
WARNING: fetching https://dl-cdn.alpinelinux.org/alpine/v3.19/main: could not connect to server (check repositories file)
WARNING: fetching https://dl-cdn.alpinelinux.org/alpine/v3.19/community: could not connect to server (check repositories file)
ERROR: unable to select packages:
  jq (no such package):
    required by: world[jq]
  kubectl (no such package):
    required by: world[kubectl]
    ```

Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as designed, tests will need a bit more going through before we can adopt them, but ran locally ok, and not enough to block release.

@smlx smlx merged commit 1e57969 into main Feb 16, 2024
16 checks passed
@smlx smlx deleted the service-annotations branch February 16, 2024 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants