refactor: move pre-rollout tasks to before templating/rollouts #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjerdo
reviewed
Oct 10, 2024
shreddedbacon
force-pushed
the
refactor-legacy
branch
2 times, most recently
from
66168c6 to
b4a909d
Compare
shreddedbacon
force-pushed
the
refactor-legacy
branch
from
b4a909d to
31bcf53
Compare
tobybellwood
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the pre-rollout tasks to run before the rollout takes place.
If a pre-rollout task needs to perform some action like putting a site into a mode to prevent traffic while the rollout takes place, running the pre-rollout tasks before the images are built and pushed can mean the site is in an unavailable state longer than needed. Running them after the images are built and pushed results in a shorter period.
The images being pushed does not mean that they are live yet, as this happens during the
Apply Deploymentsphase of a build, and pre-rollout tasks will now run betweenImage PushandTemplating Deployments. If pre-rollout tasks fail, there is no impact to the running environment as no deployment changes will have taken place.closes #375