Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: only generate schedules if resource types have backups #271

Merged
merged 6 commits into from
Feb 13, 2024

Conversation

shreddedbacon
Copy link
Member

Refactoring the schedule generation to only generate if a resource type contains items that can be backed up

Closing issues

closes #270

@shreddedbacon shreddedbacon marked this pull request as ready for review December 11, 2023 06:13
@shreddedbacon shreddedbacon force-pushed the no-backups-no-schedule branch from 242c616 to 0e274e7 Compare January 18, 2024 23:45
@shreddedbacon shreddedbacon added this to the 2.18.0 milestone Feb 6, 2024
…ests as examples for building lagoon environments from
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With all tests passing, I'm happy to approve this. Will observe in test cluster

@shreddedbacon shreddedbacon merged commit 6301f2c into main Feb 13, 2024
2 checks passed
@shreddedbacon shreddedbacon deleted the no-backups-no-schedule branch February 13, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Environments with nothing to backup still create schedules
2 participants