Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: basic service port override when the service is set #269

Merged
merged 1 commit into from
Nov 27, 2023
Merged

fix: basic service port override when the service is set #269

merged 1 commit into from
Nov 27, 2023

Conversation

shreddedbacon
Copy link
Member

The step where the service is created didn't know about the port change capabilities of the basic service type. This fixes it so that it will set the override if it is set.

@shreddedbacon shreddedbacon marked this pull request as ready for review November 26, 2023 22:06
tobybellwood
tobybellwood approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested working. It might be a weird side-effect of the double apply, but this is good to go.

@shreddedbacon
Copy link
Member Author

tested working. It might be a weird side-effect of the double apply, but this is good to go.

Yeah, it is

@shreddedbacon shreddedbacon merged commit e28968a into main Nov 27, 2023
2 checks passed
@shreddedbacon shreddedbacon deleted the fix-basic-port-setting branch November 27, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreddedbacon @tobybellwood