Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change the default prune and check times to be different to reduce clashes #258

Merged
merged 2 commits into from
Nov 27, 2023
Merged

fix: change the default prune and check times to be different to reduce clashes #258

merged 2 commits into from
Nov 27, 2023

Conversation

shreddedbacon
Copy link
Member

closes #257

@shreddedbacon shreddedbacon force-pushed the prune-check-schedule-clash branch from 7b5ff92 to 36666df Compare November 7, 2023 21:33
@shreddedbacon shreddedbacon marked this pull request as ready for review November 7, 2023 22:19
@shreddedbacon shreddedbacon force-pushed the prune-check-schedule-clash branch from 36666df to b23a9ed Compare November 27, 2023 01:39
@shreddedbacon shreddedbacon force-pushed the prune-check-schedule-clash branch from b23a9ed to 5e45987 Compare November 27, 2023 01:43
@shreddedbacon shreddedbacon changed the title fix: change the default prune and check times to be different to prevent clashes fix: change the default prune and check times to be different to reduce clashes Nov 27, 2023
tobybellwood
tobybellwood approved these changes Nov 27, 2023
View reviewed changes
Copy link
Member

@tobybellwood tobybellwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should handle the edge case well. Approved

@shreddedbacon shreddedbacon enabled auto-merge (squash) November 27, 2023 01:52
@shreddedbacon shreddedbacon merged commit 2d62373 into main Nov 27, 2023
2 checks passed
@shreddedbacon shreddedbacon deleted the prune-check-schedule-clash branch November 27, 2023 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobybellwood tobybellwood tobybellwood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ensure k8up schedules do not conflict with each other
2 participants
@shreddedbacon @tobybellwood