Experimental device requests #204
Conversation
rocketeerbkw
force-pushed
the
experimental-device-requests
branch
from
18eb5ee to
aae5606
Compare
| @@ -1445,6 +1445,9 @@ do | |||
| fi | |||
| fi | |||
|
|
|||
| # handle gpu configuration | |||
There was a problem hiding this comment.
We could wrap this experimental feature under a flag like this https://github.com/uselagoon/build-deploy-tool/blob/main/legacy/build-deploy-docker-compose.sh#L845
ADMIN_LAGOON_FEATURE_FLAG_X are only settable on the remote cluster, so we have some constraint to where this can be enabled.
if [ "$ADMIN_LAGOON_FEATURE_FLAG_EXPERIMENTAL_GPU_SUPPORT" = enabled ]; then
. /kubectl-build-deploy/scripts/exec-gpu-generation.sh
fi
There was a problem hiding this comment.
Do we need a flag at all? Any cluster that doesn't have the k8s plugins installed and GPU nodes available will just fail to schedule pods and cause a deployment failure.
There was a problem hiding this comment.
Right, I guess that is ok. We can re-evaluate the feature wrapping later. In IO cloud if we ever want to restrict users some how, we will need some sort of flagging system though, problem for another day though.
Experimental support for GPU requests. This will eventually go away in favor of lagoon resource workload management in the API. Leaving for now as used in PoCs