Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modified: src/v2i-hub/ImmediateForwardPlugin/README.md #668

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

jwillmartin
Copy link
Contributor

modified:   src/v2i-hub/ImmediateForwardPlugin/manifest.json

PR Details

Description

Updated manifest.json and README to use the default RSU 4.1 port. This will help avoid confusion and accidental misconfiguration.

Related Issue

Motivation and Context

How Has This Been Tested?

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

	modified:   src/v2i-hub/ImmediateForwardPlugin/manifest.json
@@ -21,7 +21,7 @@ This plugin has several configuration parameters. Below these are listed out as
"name": "East Intersection Cohda", /** String Name for RSU **/
"rsuSpec": "RSU4.1", /** Version of Immediate Forward Protocol to use (RSU4.1 or NTCIP1218) **/
"address": "127.0.0.1", /** Address of RSU **/
"port": 3745, /** Port for Immediate Forward protocol on RSU **/
"port": 1516, /** Default port for Immediate Forward protocol on RSU4.1 **/
Copy link
Contributor

@paulbourelly999 paulbourelly999 Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On line 17 can you add something like :

Tip

Default Immediate Forward protocol port on RSU4.1 is 1516

Copy link
Contributor

@paulbourelly999 paulbourelly999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny addition

@jwillmartin jwillmartin merged commit 346100d into develop Jan 22, 2025
1 of 2 checks passed
@jwillmartin jwillmartin deleted the ifm-manifest-change branch January 22, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants