Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Immediate Forward Plugin configuration #658

Merged
merged 12 commits into from
Jan 21, 2025

Conversation

paulbourelly999
Copy link
Contributor

@paulbourelly999 paulbourelly999 commented Dec 13, 2024

PR Details

Description

New configuration allows for unlimited RSU connections each with independently configurable options for :

Related Issue

VH-1251

Motivation and Context

Improve functionality for allow each Immediate Forward connection to an RSU to be independently configurable and add configuration parameters for RSU spec in preparation for NTCIP 1218 support

How Has This Been Tested?

Local Integration Testing and unit testing
Integration testing was done using pcap sender scripts sending binary spat data to spat plugin and tcpdump to listen to outgoing UDP from immediate forward plugin

Types of changes

  • Defect fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that cause existing functionality to change)

Checklist:

  • I have added any new packages to the sonar-scanner.properties file
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
    V2XHUB Contributing Guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@paulbourelly999 paulbourelly999 marked this pull request as ready for review December 20, 2024 19:45
New configuration allows for unlimited RSU connections of potentially
differect specs
Fix Bug introduced by previous PR to prevent IMF from sending messages
Using new IMF configuration parsing code
@paulbourelly999 paulbourelly999 force-pushed the vh-1251-improve-imf-plugin-configuration branch from 2f2ac26 to be1e312 Compare December 23, 2024 21:41
@dan-du-car
Copy link
Contributor

const char* Key_SkippedNoDsrcMetadata = "Messages Skipped (No DSRC metadata)"; const char* Key_SkippedNoMessageRoute = "Messages Skipped (No route)";
What is the difference between no DSRC and no route?

@paulbourelly999
Copy link
Contributor Author

const char* Key_SkippedNoDsrcMetadata = "Messages Skipped (No DSRC metadata)"; const char* Key_SkippedNoMessageRoute = "Messages Skipped (No route)"; What is the difference between no DSRC and no route?

No Message Route is triggered when a message is received by the immediate forward plugin but it is not on of the messages included in the immediate forward configuration. For example if a SPAT message is received but there is not SPAT IMF config

No DSRC Metatdata reference to metadata provided when each messages is broadcast by another plugin. This metadata includes PSID and channel. Please see the IVpMessage.h file

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
66.99% Line Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@paulbourelly999 paulbourelly999 merged commit fb186d2 into develop Jan 21, 2025
1 of 3 checks passed
@paulbourelly999 paulbourelly999 deleted the vh-1251-improve-imf-plugin-configuration branch January 21, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants