[FIX] ACH Payment Unbalanced Entry #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atchuthan
force-pushed
the
14.0-MIG-account_banking_ach_discount-unbalanced-entry
branch
from
223c2c3 to
2be02ad
Compare
Murtaza-OSI
force-pushed
the
14.0-MIG-account_banking_ach_discount
branch
from
d77080d to
8da666a
Compare
…count_banking_ach_discount-unbalanced-entry
|
@atchuthan Thanks for your contribution. I have reviewed your fix and it will discontinue to create discount journal items. That was not the original intent of the module. We want to record a discount amount in a separate account (which is configured at payment term line level) for an income/expense accounting report. There should be bugs somewhere else. I leave this PR open. Thank you. |
atchuthan
force-pushed
the
14.0-MIG-account_banking_ach_discount-unbalanced-entry
branch
from
7c519f5 to
b2fa98f
Compare
dreispt
force-pushed
the
14.0-MIG-account_banking_ach_discount
branch
2 times, most recently
from
7119312 to
e00eee6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Internal Notes: [ID:20716] Issue 1057: ACH Payment Unbalanced Entry)
depends on OCA#73
cc: @SodexisTeam