Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix Incremental Delivery payloads deep merging and root patches #3124

Merged
merged 11 commits into from
Apr 1, 2023

Conversation

kitten
Copy link
Member

@kitten kitten commented Apr 1, 2023

Resolves #3122

Summary

This deeply merges (while cloning) result sets from Incremental Delivery results, and handles deep merges on the root payload as well, which we previously didn't realise was a legal usage of @defer.

Set of changes

  • Add deep-clone merging of incremental delivery payloads
  • Add handling of merging patches into root (i.e. path: [])

@kitten kitten requested a review from JoviDeCroock April 1, 2023 13:49
@kitten kitten merged commit 5c78394 into main Apr 1, 2023
@kitten kitten deleted the fix-root-query-defer branch April 1, 2023 16:23
@github-actions github-actions bot mentioned this pull request Apr 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deferred fragments on Query produces undefined key in data response
3 participants