Add Telemetry #49
Merged
Add Telemetry #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platforms/cloudflare.ts
Outdated
| routeFunction, | ||
| { | ||
| sdk: SDK_TELEMETRY, | ||
| platform: "cloudflare", |
There was a problem hiding this comment.
Why don't we have runtime here?
There was a problem hiding this comment.
no process object in cloudflare. I couldn't find an equivalent
platforms/express.ts
Outdated
| { | ||
| sdk: SDK_TELEMETRY, | ||
| platform: "express", | ||
| runtime: `node@${process.version}`, |
There was a problem hiding this comment.
How can we make sure it's node? It can also be bun etc... can we somehow detect that?
There was a problem hiding this comment.
This applies to all the configs
There was a problem hiding this comment.
|
I think we can change |
|
The user should be able to opt out of telemetry logging, but it can be enabled by default |
fahreddinozcan
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds telemetry headers to workflow requests.