Skip to content

Commit

Permalink
fix: build cleanup/incl. favicons
Browse files Browse the repository at this point in the history
  • Loading branch information
Rexogamer committed Feb 28, 2024
1 parent 1383371 commit b8e1863
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-android.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ jobs:
- name: Install dependencies and prepare assets
run: yarn install && npx react-native-asset
- name: Bundle the JS
run: npx react-native bundle --platform android --entry-file ./index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res
run: yarn react-native bundle --platform android --entry-file ./index.js --bundle-output android/app/src/main/assets/index.android.bundle --assets-dest android/app/src/main/res
- name: Build the app
run: npx react-native build-android --tasks assembleDebug
run: yarn react-native build-android --tasks assembleDebug
- name: Rename debug APKs
run: |
mv app-arm64-v8a-debug.apk RVMob-Debug-${{ github.sha }}-arm64-v8a.apk
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"test": "jest",
"lint": "eslint .",
"web": "webpack-dev-server --config webpack.config.js --hot --mode=development",
"web-release": "webpack --config webpack.config.js",
"web-release": "webpack --config webpack.config.js --mode=production",
"postinstall": "patch-package"
},
"dependencies": {
Expand Down
1 change: 1 addition & 0 deletions webpack.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ module.exports = {
plugins: [
new HtmlWebpackPlugin({
template: path.join(__dirname, 'web/index.html'),
favicon: path.join(__dirname, 'public/favicon.ico'),
}),
new webpack.DefinePlugin({
// See: https://github.com/necolas/react-native-web/issues/349
Expand Down

0 comments on commit b8e1863

Please sign in to comment.