Improved REST API permission system (FooCard authentication) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…account_id in payload
… tests actually testing those libraries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The REST API, in its current form, provides only one way of accessing it, namely through API tokens. The permission system for the API tokens is currently very basic and there is no easy way of implementing more specialised endpoints, such as purchase cancelling, and controlling which users may access those endpoints and how they can interact with them.
What we want is an additional type of API token, a card token, that is generated based on the FooCard that was used to login. Using card token would make it possible to for example implement purchase cancelling for purchases associated with the card. The regular API tokens could therefore be limited to read-only operations, whereas a card token would be required in order to do write operations, such as making a purchase or canceling one.