Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

Fix callback behavior when no explicit url is specified in the query #8

Closed
wants to merge 1 commit into from

Conversation

mirceanis
Copy link
Contributor

What's here

This fixes #7
When using the unified request URL ( https://id.uport.me/req/... ) without an explicit callback type and url in the query, the app defaults to postback but because no postback url is set either, it does nothing with the response.

Testing

Open the example URL in the description of #7 on a mobile device.
After accepting or rejecting the call, the app should call back to https://example.com

simonas-notcat
simonas-notcat previously approved these changes Nov 2, 2018
Copy link
Contributor

@simonas-notcat simonas-notcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@simonas-notcat
Copy link
Contributor

I take that back :) Tests are failing @mirceanis

@simonas-notcat simonas-notcat dismissed their stale review November 2, 2018 14:15

Tests are failing

@mirceanis
Copy link
Contributor Author

mirceanis commented Nov 2, 2018

I saw.
I think the tests are wrong @simonas-notcat

For example, here the description makes sense but the test is actually matching something completely different


  ● performCallback › postback and redirect_url not set › performs returnToApp

    SagaTestError: 
    call expectation unmet:
    
    Expected
    --------
    { context: null,
      fn: [Function: postBackToServer],
      args: 
       [ { postback: undefined,
           callback_url: 'https://mydapp.com/hello?mysite=hello' },
         { status: 'ok' } ] }
    
    Actual:
    ------
    1. { context: null,
      fn: [Function: returnToApp],
      args: 

@mirceanis mirceanis deleted the bugfix/7-app-is-wrongfully-using-postback branch January 22, 2020 11:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App is wrongfully using postback
2 participants