[CC-1376] jwt token #191
Merged
[CC-1376] jwt token #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Ryouzanpaku
commented
Aug 13, 2024
•
Ryouzanpaku
commented
- Dropped support of Dev environment, since it is rarely used and would require extra handling now that its not supported by all Apis.
- Also contains automatic reformatting
- Not in this PR:
- Paypage handling.
- Actual use of bearer authentication.
- refactor to support multiple apis. - add create request fo jwt token.
- Check if JWT is required for request. - Create token before resource request. - Validate expiry of existing token
|
No New Or Fixed Issues Found |
- run cs fixer.
- Cleanup code. - Simplify method parameters for requests.
- Simplify automatic token creation unit test.
- Add PHPDocs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.