-
-
Notifications
You must be signed in to change notification settings - Fork 267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Stepper #987
feat: Stepper #987
Conversation
@epr3 Thanks for working on this. However I'm not sure if this component is really needed. From what I can see it's closely resembles the |
@zernonia Yes, I agree. I've seen most implementations follow a I was thinking of making this component different than the
I referenced this and this for the features. I would have used a Let me know your thoughts! Feel free to close the PR if the component is overlapping the |
Thanks for the explanation @epr3 ! If that's the case let's continue on with this component! 🚀 |
Deploying radix-vue with
|
Latest commit: |
cbae586
|
Status: | ✅ Deploy successful! |
Preview URL: | https://f23c3130.radix-vue.pages.dev |
Branch Preview URL: | https://805-feature-stepper.radix-vue.pages.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for create working on this component @epr3 !! Just suggestion regarding some implementation.
Also, as there's no WAI-ARIA spec for Stepper, I think we need to think about how to inform user properly (Screen reader/Voiceover mode). Currently the a11y is not well covered yet, especially informing how many steps there were.
@zernonia Thank you very much for the feedback! I can think of adding a visibility hidden div with |
This is not a bad suggestion! I was looking into the having role |
Closes #805.
Stepper implementation composed of:
Root
,List
,Item
,Indicator
,Title
,Description
.Item
has local context for supplying data to underlying components.Main features:
linear
property ensures linear navigation of stepperTitle
for accessibility (like theDialog
)orientation
propertyThe component is fully documented and tested.
More context here: #987 (comment)
Any feedback is appreciated. 🚀