docs: fix 404 when clicking on "Date Range Field" DemoContainer #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the home page, when a user clicks on a demo container with a title
containing more than two words, they will get a 404.
For example, "Date Range Picker" generates the link:
`/components/date-range%20picker.html` rather than the correct link
`/components/date-range%20picker.html`.
The component responsible for generating this url is `<DemoContainer>`. It
uses the `title` prop to generate the link. When a title has a space, it currently
substitutes a hyphen for the space using `title.replace(" ", "-")`.
However, `.replace()` only replaces the first instance when passed a string as
the pattern, so only the first `" "` is replaced with a `"-"`.
This updates to use a regex in `title.replace()` so that each instance of
whitespace is replaced with a hyphen.
|
Thanks for the issue and fix @jxjj ! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the home page, when a user clicks on a demo container with a title containing more than two words, they will get a 404.
For example, "Date Range Picker" generates the link:
/components/date-range%20picker.htmlrather than the correct link/components/date-range-picker.html.The component responsible for generating this url is
<DemoContainer>. It uses thetitleprop to generate the link. When a title has a space, it currently substitutes a hyphen for the space usingtitle.replace(" ", "-").However,
.replace()only replaces the first instance when passed a string as the pattern, so only the first" "is replaced with a"-".This updates to use a regex in
title.replace()so that each instance of whitespace is replaced with a hyphen.Resolves #893