Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix lint issues #879

Merged
merged 1 commit into from
May 1, 2024
Merged

chore: fix lint issues #879

merged 1 commit into from
May 1, 2024

Conversation

onmax
Copy link
Collaborator

@onmax onmax commented Apr 26, 2024

It would be nice to have custom rules in the eslint.config.cjs for the files **/**.*.story.vue and turn off rules like no-console and no-alert, but I am not sure how to implement it.

So, instead I am using // disable-next-line no-console in multiple stories

Copy link

cloudflare-workers-and-pages bot commented Apr 26, 2024

Deploying radix-vue with  Cloudflare Pages  Cloudflare Pages

Latest commit: 19f313d
Status: ✅  Deploy successful!
Preview URL: https://b5dc0a40.radix-vue.pages.dev
Branch Preview URL: https://onmax-lint-fix.radix-vue.pages.dev

View logs

Copy link
Member

@zernonia zernonia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we purposely exclude linting story files because we wanna keep some code for easier debugging. We don't really need to add those // eslint-disable-next-line no-alert too as it's just dev environment.

Let's revert that ya 😁

@onmax onmax force-pushed the onmax/lint-fix branch from 11b85ad to 19f313d Compare May 1, 2024 08:26
@onmax
Copy link
Collaborator Author

onmax commented May 1, 2024

Perfect. I've added some eslint rules to ignore stories.

Can I create another PR updating eslint to v9 and flat config? I will try the changes to the minimum.

Or I can keep using this pr... let me know what you think

@zernonia
Copy link
Member

zernonia commented May 1, 2024

Awesome!!!
Let's create another PR for v9. I heard some bad experience with v9 🙈

@zernonia zernonia merged commit a28c92e into main May 1, 2024
5 checks passed
@sadeghbarati sadeghbarati deleted the onmax/lint-fix branch June 26, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants