refactor(useCalendar): include calendar identifier when computing heading value #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice addition @epr3 ! LGTM! 🚀 Also, welcome to the team! 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR extends the
useDateFormatterfunction to also include thecalendaridentifier in its options, so you get the month names translated into your requiredlocaleand also updated the utility function to be able to acceptoptions.It also updates the
useCalendarheadingValueto use thecalendaridentifier when computing thefullMonth,fullYearandfullMonthAndYear.Plus, the
props.placeholderfunction has been updated to useisEqualMonthso any calendar system change would update thegrid.cc @sadeghbarati for pointing out the bug and providing me with reproductions.