Fix document.activeElement not being correct when components are use inside custom elements #1570
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1564
Reverts fixes from #1314
This pull requests address the fact that
docuement.activeElement
will be incorrect when components are used inside of a custom element. After some tests here is what I found:document.activeElement
will be the host of the custom element and the actual active element can be retrived byactiveElement.shadowRoot.activeElement
activeElement.shadowRoot.activeElement..shadowRoot.activeElement
With these findings I have implemented a function
useActiveElement
to retrieve theactiveElement
regardless of the nestedshadowRoot
. With this function I've replace all instances ofdocument.activeElement
withuseActiveElement()
. After some tests it seems like everything still works and we do not need the fixes from #1314 anymore.