feat(SelectItem): Emit a select event when an option is selected #1513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
I see there's a failing check. But it doesn't seem to be caused by my changes as I didn't touch that part of the code. |
|
Yoo @kilobyte2007 ! I've fixed the test issue, can you please rebase the branch on |
zernonia
reviewed
Dec 31, 2024
…works for Combobox/Listbox with ListboxItem
kilobyte2007
force-pushed
the
patch-2
branch
from
fd91ce5 to
2922b10
Compare
|
Thanks for the feature OR @kilobyte2007 ! Looking good! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented a
selectevent/emit on theSelectItemso it's consistent withListbox/Combobox.This is especially important when using
multiplebecause we cannot rely onupdate:modelValueas we only need the specific item that was last selected.Let me know if you have any questions or objections!