refactor!: update runtime/node structure
#392
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
runtime/node to avoid indexruntime/node structure
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
vicb
reviewed
Jan 25, 2025
| @@ -1,3 +1,2 @@ | |||
| export { default as node } from "./node"; | |||
| export { default as nodeless } from "./nodeless"; | |||
| export { default as cloudflare } from "./cloudflare"; | |||
There was a problem hiding this comment.
Hey @pi0, do you think it would be possible to keep the cloudflare preset here for one more RC and remove it in the next one? Maybe moving the file to node/$cloudflare-<module>.ts.
This might allow for a smoother transition?
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a major refactor on
runtime/node/*structure to avoid/indexentries. /cc @vicbThis makes node structure closer to Node.js lib dir (preview)
Since
@cloudflare/unenv-presetis now fully externalized, we can safety remove entries.