fix: use native require cache of loaded entries only (v1) (#349)

Co-authored-by: Jordan Pittman <[email protected]>

src/jiti.ts

@@ -344,7 +344,10 @@ export default function createJITI(
       return _interopDefault(cache[filename]?.exports);
     }
     if (opts.requireCache && nativeRequire.cache[filename]) {
-      return _interopDefault(nativeRequire.cache[filename]?.exports);
+      const cacheEntry = nativeRequire.cache[filename];
+      if (cacheEntry?.loaded) {
+        return _interopDefault(cacheEntry.exports);
+      }
     }
 
     // Read source

test/__snapshots__/fixtures.test.ts.snap

@@ -74,6 +74,14 @@ Enter Identifier
 Enter Literal"
 `;
 
+exports[`fixtures > require-esm > stderr 1`] = `
+[
+  "ExperimentalWarning: CommonJS module <cwd>/index.cjs is loading ES Module <cwd>/_dist/esm.js using require().",
+]
+`;
+
+exports[`fixtures > require-esm > stdout 1`] = `"Works!"`;
+
 exports[`fixtures > syntax > stdout 1`] = `
 "Optional chaining: undefined
 Nullish coalescing: 0

test/fixtures.test.ts

@@ -57,7 +57,7 @@ describe("fixtures", async () => {
 
       if (name.includes("error")) {
         expect(extractErrors(cleanUpSnap(stderr))).toMatchSnapshot("stderr");
-      } else if (name === "mixed" && nodeMajor >= 22) {
+      } else if (nodeMajor >= 22 && ["mixed", "require-esm"].includes(name)) {
         expect(extractErrors(cleanUpSnap(stderr))).toMatchSnapshot("stderr");
       } else {
         // Expect no error by default

test/fixtures/require-esm/_dist/esm.js

@@ -0,0 +1,3 @@
+import fn from "./fn.js";
+import file from "./file";
+export default { fn, file };

test/fixtures/require-esm/_dist/file.js

@@ -0,0 +1 @@
+module.exports = {};

test/fixtures/require-esm/_dist/fn.js

@@ -0,0 +1 @@
+module.exports = function _() {};

test/fixtures/require-esm/index.cjs

@@ -0,0 +1,18 @@
+async function run() {
+  let mod;
+  try {
+    mod = require("./_dist/esm.js");
+  } catch {
+    const createJiti = require("../../../lib/index.js");
+    const jiti = createJiti(__filename, { interopDefault: true });
+    mod = await jiti.import("./_dist/esm.js");
+  }
+  mod = mod.default;
+  if (typeof mod.fn === "function") {
+    console.log("Works!");
+    return;
+  }
+  console.error("broken!", { mod });
+}
+
+run();

test/fixtures/require-esm/package.json

@@ -0,0 +1,3 @@
+{
+  "type": "-"
+}