-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support throwing responses in upgrade
hook
#91
Conversation
…iformly across adapters.
Seems nice direction! It might take me little longer to jump on proper review. |
@pi0 Any chance you may be able to take a look at this PR soon? |
@pi0 Circling back around on this, I see these changes as a pseudo-prerequisite for getting Web Sockets added to SvelteKit. I'm happy to work on any changes or feedback that needs to be incorporated and would love to get tests running if some exist. |
@pi0 Can you assist with the logic around the errors? I see that the tests expect ws.Error to be populated on unauthorized response, how is that properly set cross platform? |
Of course. Applogizes again for delay. I will directly check tests and changes ASAP to move it forward. |
Thanks @pi0! I hope you had a good new year. We're thankful for any time you're able to spare to take a look at this |
upgrade
hook
Thanks again and sorry for the delay. Pushed a few changes:
|
This PR should introduce support for throwing for errors or returning for success from the upgrade handler, all the interfacing with the adapters should remain the same.