-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/ccf #2122
Feat/ccf #2122
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2122 +/- ##
=======================================
Coverage 93.92% 93.93%
=======================================
Files 135 135
Lines 13335 13356 +21
=======================================
+ Hits 12525 12546 +21
Misses 810 810 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one very minor comment about the docstring
darts/utils/statistics.py
Outdated
) -> None: | ||
""" | ||
Plots the Cross Correlation Function (CCF) between `ts` and `ts_other`, highlighting it at lag `m`, with | ||
corresponding significance interval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a link to the documentation of statsmodels.ccovf?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 thanks
Summary
darts.utils.statistics.plot_ccf
: the Cross Correlation Function (CCF) similar to the Autocorrelation Function (ACF). CCF can be used to compute the corrolation between a time series (e.g. target series) and the of lagged values of another time series (e.g. covariates series).