Skip to content

Commit

Permalink
Fix CSS variable checker breaking build
Browse files Browse the repository at this point in the history
For a while now a false negative would occur with the css variable
checker (which goal is to ensure we don't reference undefined css
variables). Turns out, in omni-search.css one of the
var(--font-size-medium), even though it looked correct and with the
right characters would not pass a JavaScript equality check thus
resulting in the false negative. I just rewrote that line to fix the
problem. Even the diff says that they are different, but offer no
indication of what is different. 🤷
  • Loading branch information
hojberg committed Oct 28, 2024
1 parent 3318986 commit fa59e77
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/css/unison-share/omni-search.css
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,7 @@

& .icon {
color: var(--u-color_icon_subdued);
font-size: var(--fontsize-medium);
font-size: var(--font-size-medium);
}
}

Expand Down
4 changes: 3 additions & 1 deletion src/css/unison-share/page/code-page.css
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@
--readable-column-width-medium originally is 43 and we're adding 2rem;
* */
--readable-column-width-medium_original: 43rem;
--readable-column-width-medium: calc(var(--readable-column-width-medium_original) + 2rem);
--readable-column-width-medium: calc(
var(--readable-column-width-medium_original) + 2rem
);
}

.code-page .sidebar .namespace-header {
Expand Down

0 comments on commit fa59e77

Please sign in to comment.