Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SyncV2 skeleton and add migration to store serialized components #32

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

ChrisPenner
Copy link
Contributor

@ChrisPenner ChrisPenner commented Jan 24, 2025

Overview

  • TODO: Before deploying ensure you've created BOTH the migration queue table and the serialised component tables.

Adds the API and handlers for syncv2 pulls, as well as code to run a migration to backfill storing serialized rows for all existing code stored in Share (this'll take a while to run I think 😓 )

Implementation notes

  • Adds new syncv2 'download-entities' endpoint which takes a HashJWT for a given root and will send a stream of all dependencies of that root.

Test coverage

I've done some manual testing, but this is going to remain experimental until we've bullet-proofed it in UCM anyways and shouldn't affect anyone who's not using an experimental UCM build

Loose ends

I have branches in progress for these:

  • Sort entities in dependency order
  • Allow UCM to pass hashes whose dependencies should be omitted from the stream

@ChrisPenner ChrisPenner marked this pull request as ready for review January 24, 2025 21:25
@ChrisPenner ChrisPenner force-pushed the syncv2/migrate-entities branch from d32536c to 71f18bd Compare January 24, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant