FormulaOnsets #82
Open
FormulaOnsets #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
==========================================
- Coverage 72.82% 70.32% -2.51%
==========================================
Files 10 10
Lines 357 374 +17
==========================================
+ Hits 260 263 +3
- Misses 97 111 +14 ☔ View full report in Codecov by Sentry. |
| axislegend(ax) | ||
| f | ||
|
|
||
| # Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.` |
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| # Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.` | |
| # Voila - the inter-onset intervals are `20` samples longer for condition `B`, exactly as specified.` |
Comment on lines
+157
to
+158
|
|
||
|
|
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was fun, even though specificatio is a bit ugly (similar to the components interface issue, one always has to specify formula and betas separately...)
In any case, I was wondering if we should point the implementation of UniformOnset to the FormulaUniformOnset and simply use an intercept-only 0~1 formula.
But on the flip case, I benchmarked it, and it is significantly slower (makes sense, we have to generate a huge designmatrix first).
Difference is 127µs vs. 32ms...
Probably best to keep both for now?