Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Disable vote btn when not logged in #206

Merged
merged 4 commits into from
Nov 8, 2024

Conversation

josephpdf
Copy link
Contributor

Pull Request

Changes description

I modified the button behavior based on the wallet connection status:

  • When no wallet is connected, the vote button remains disabled and added a short description.
  • Upon connecting a wallet, the button becomes active and clickable.

Current output

  • Disconnected wallet: Button is disabled.
    Captura de pantalla 2024-11-07 120943
  • Connected wallet: Button is enabled.
    Captura de pantalla 2024-11-07 120923

Time spent breakdown

  1. Research & Planning: 1 hour
  2. Code & Testing: 1.5 hour
  3. Code review and formatting: 30 minutes

Comments

This update improves the user experience by ensuring that the vote button only becomes interactive when a wallet is connected, aligning with the intended app functionality.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still uploading changes to this file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still uploading changes to this file

Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are still uploading changes to files we do not want to be modified

@josephpdf josephpdf requested a review from adrianvrj November 8, 2024 16:35
Copy link
Member

@adrianvrj adrianvrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, great work homie!

@adrianvrj adrianvrj changed the title feat: Desabled vote buttom [feat] Disable vote btn when not logged in Nov 8, 2024
@adrianvrj adrianvrj merged commit 0f3c06e into undefinedorgcr:dev Nov 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Disable vote btn when wallet not connected
2 participants